✨ enhance the schema.rb parser to support Constraints #1408

tnyo43 · 2025-04-20T06:54:23Z

Issue

resolve:

Why is this change needed?

We introduced constraints of schema and update tbls and Prisma parser to support the feature.
This PR will update schema.rb parser to support constraints.

ref

introduce constraints and update tbls parser ✨ feat: enhance schema to adopt constraints data #1168
update Prisma parser ✨ enhance the Prisma parser to support Constraints #1386

What would you like reviewers to focus on?

the constraints are parsed properly
- The schema.rb parser will support "PRIMARY KEY", "FOREIGN KEY", "UNIQUE" and "CHECK" constraints.
the tests are appropriate

Testing Verification

About the parser, I updated some test cases
About the application, I checked the behaviour in the following steps
1. copy the following schema and save on your local PC (that's a slight modified copy of this file)
2. run pnpm run build --filter @liam-hq/cli to build cli
3. run node frontend/packages/cli/dist-cli/bin/cli.js erd build --input schema.rb to generate scripts
4. run npx http-server dist to run the application and go to http://localhost:8080/
5. click "users" table and see the Constraints section of its table details

schema.rb

create_table "companies", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Represents organizations using the system. Each company is a top-level entity that owns departments, users, and projects.", force: :cascade do |t|
  t.string "name", null: false, comment: "The name of the company."
  t.string "address", null: false, comment: "The registered address of the company."
end

create_table "departments", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Represents departments within a company, organizing users into functional groups.", force: :cascade do |t|
  t.string "name", null: false, comment: "The name of the department."
  t.uuid "company_id", null: false, comment: "Foreign key linking the department to a company."
  t.index ["company_id"], name: "index_departments_on_company_id"
end

create_table "users", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Represents employees or members of a company, who are assigned roles and tasks.", force: :cascade do |t|
  t.uuid "company_id", null: false, comment: "Foreign key linking the user to a company."
  t.uuid "department_id", null: false, comment: "Foreign key linking the user to a department."
  t.datetime "created_at", null: false, comment: "The timestamp when the user was created."
  t.string "name", default: "new user", null: true, comment: "The user's full name."
  t.string "email", null: false, comment: "The user's email address."
  t.integer "age", default: 30, null: true, comment: "The user's age."
  t.boolean "is_deleted", default: false, null: true, comment: "Indicates whether the user is deleted (soft delete)."
  t.string "user_name", null: false, comment: "A unique identifier or login name for the user."
  t.index ["company_id"], name: "index_users_on_company_id"
  t.index ["department_id"], name: "index_users_on_department_id"
  t.index ["email"], name: "index_users_on_email", unique: true
end

create_table "roles", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Defines roles that can be assigned to users, such as 'Admin' or 'Manager'.", force: :cascade do |t|
  t.string "name", null: false, comment: "The name of the role."
  t.string "description", comment: "A brief description of the role's purpose or permissions."
end

create_table "user_roles", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Associates users with roles to define their permissions within the company.", force: :cascade do |t|
  t.uuid "user_id", null: false, comment: "Foreign key linking to the user."
  t.uuid "role_id", null: false, comment: "Foreign key linking to the role."
  t.index ["user_id", "role_id"], unique: true, name: "index_user_roles_on_user_id_and_role_id", comment: "Ensures that each user-role pair is unique."
end

create_table "projects", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Represents projects managed within a company. Projects are linked to tasks and users.", force: :cascade do |t|
  t.string "name", null: false, comment: "The name of the project."
  t.text "description", comment: "A detailed description of the project."
  t.uuid "company_id", null: false, comment: "Foreign key linking the project to a company."
  t.index ["company_id"], name: "index_projects_on_company_id"
end

create_table "project_assignments", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Associates users with projects they are assigned to work on.", force: :cascade do |t|
  t.uuid "user_id", null: false, comment: "Foreign key linking to the user."
  t.uuid "project_id", null: false, comment: "Foreign key linking to the project."
  t.index ["user_id", "project_id"], unique: true, name: "index_project_assignments_on_user_id_and_project_id", comment: "Ensures that each user is uniquely assigned to a project."
end

create_table "tasks", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Represents tasks within a project, assigned to users with deadlines and statuses.", force: :cascade do |t|
  t.string "title", null: false, comment: "The title of the task."
  t.text "description", comment: "A detailed description of the task."
  t.uuid "project_id", null: false, comment: "Foreign key linking the task to a project."
  t.uuid "assigned_user_id", null: false, comment: "Foreign key linking the task to the assigned user."
  t.datetime "due_date", comment: "The deadline for completing the task."
  t.integer "status", default: 0, comment: "The current status of the task (e.g., 0: pending, 1: in progress, 2: completed)."
  t.index ["project_id"], name: "index_tasks_on_project_id"
  t.index ["assigned_user_id"], name: "index_tasks_on_assigned_user_id"
end

create_table "comments", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Stores comments on tasks, enabling discussions or updates.", force: :cascade do |t|
  t.text "content", null: false, comment: "The content of the comment."
  t.uuid "task_id", null: false, comment: "Foreign key linking the comment to a task."
  t.uuid "user_id", null: false, comment: "Foreign key linking the comment to the user who wrote it."
  t.datetime "created_at", null: false, comment: "The timestamp when the comment was created."
  t.index ["task_id"], name: "index_comments_on_task_id"
  t.index ["user_id"], name: "index_comments_on_user_id"
end

create_table "timesheets", id: :uuid, default: -> { "gen_random_uuid()" }, comment: "Tracks time spent by users on tasks for reporting or billing purposes.", force: :cascade do |t|
  t.uuid "user_id", null: false, comment: "Foreign key linking the timesheet to a user."
  t.uuid "task_id", null: false, comment: "Foreign key linking the timesheet to a task."
  t.datetime "start_time", null: false, comment: "The timestamp when the user started working on the task."
  t.datetime "end_time", comment: "The timestamp when the user stopped working on the task."
  t.integer "duration_minutes", null: false, comment: "The total duration of work in minutes."
  t.index ["user_id"], name: "index_timesheets_on_user_id"
  t.index ["task_id"], name: "index_timesheets_on_task_id"
end

add_foreign_key "departments", "companies", column: "company_id", name: "fk_departments_company_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "users", "companies", column: "company_id", name: "fk_users_company_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "users", "departments", column: "department_id", name: "fk_users_department_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "user_roles", "users", column: "user_id", name: "fk_user_roles_user_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "user_roles", "roles", column: "role_id", name: "fk_user_roles_role_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "projects", "companies", column: "company_id", name: "fk_projects_company_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "project_assignments", "users", column: "user_id", name: "fk_project_assignments_user_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "project_assignments", "projects", column: "project_id", name: "fk_project_assignments_project_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "tasks", "projects", column: "project_id", name: "fk_tasks_project_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "tasks", "users", column: "assigned_user_id", name: "fk_tasks_assigned_user_id", on_update: :restrict, on_delete: :restrict
add_foreign_key "comments", "tasks", column: "task_id", name: "fk_comments_task_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "comments", "users", column: "user_id", name: "fk_comments_user_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "timesheets", "users", column: "user_id", name: "fk_timesheets_user_id", on_update: :restrict, on_delete: :cascade
add_foreign_key "timesheets", "tasks", column: "task_id", name: "fk_timesheets_task_id", on_update: :restrict, on_delete: :cascade
add_check_constraint "users", "age >= 0 and age < 20", name: "age_range_check"

What was done

🤖 Generated by PR Agent at `8d71055`

Add support for parsing constraints in the schema.rb parser
- Handle PRIMARY KEY, FOREIGN KEY, UNIQUE, and CHECK constraints
- Store constraints in the table schema structure
Update and expand test cases to verify constraint parsing
- Add tests for unique indexes, foreign keys, and check constraints
Add factory functions for constraint objects in schema utilities
Update schema exports to include new constraint types and factories

Detailed Changes

Relevant files

Enhancement

parser.ts `Add constraint extraction and storage to schema.rb parser` frontend/packages/db-structure/src/parser/schemarb/parser.ts Add logic to extract and store PRIMARY KEY, FOREIGN KEY, UNIQUE, and CHECK constraints Update table creation to include constraints in schema Implement extraction of check constraints and foreign key options Store constraints in table objects and handle relevant parser methods	+134/-13
factories.ts `Add constraint factories for schema objects` frontend/packages/db-structure/src/schema/factories.ts Add factory functions for PRIMARY KEY, FOREIGN KEY, UNIQUE, and CHECK constraints Export new constraint factories for use in tests and parser	+44/-0
index.ts `Export constraint types and factories from schema module` frontend/packages/db-structure/src/schema/index.ts Export new constraint types and factories (PRIMARY KEY, FOREIGN KEY, UNIQUE, CHECK) Update exports to support new constraint handling in parser and tests	+5/-0

Tests

index.test.ts `Add and update tests for constraint parsing` frontend/packages/db-structure/src/parser/schemarb/index.test.ts Expand tests to verify parsing of constraints (PRIMARY KEY, FOREIGN KEY, UNIQUE, CHECK) Update expected schema objects to include constraints Add new test cases for check constraints and constraint details	+171/-30

Documentation

wet-zoos-add.md `Add changeset for schema.rb constraint support` .changeset/wet-zoos-add.md Add changeset entry describing enhancement of schema.rb parser for constraints	+5/-0

Additional Notes

Need help?
Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
Check out the documentation for more information.

changeset-bot · 2025-04-20T06:54:27Z

🦋 Changeset detected

Latest commit: a59b2f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@liam-hq/db-structure	Patch
@liam-hq/cli	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel · 2025-04-20T06:54:28Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
liam-app	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 11:50am
liam-erd-sample	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 1, 2025 11:50am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
liam-docs	⬜️ Ignored (Inspect)	Visit Preview		May 1, 2025 11:50am

supabase · 2025-04-20T06:54:58Z

Updates to Preview Branch (feat/schemarb-constraints) ↗︎

Deployments	Status	Updated
Database	✅	Thu, 01 May 2025 11:47:33 UTC
Services	✅	Thu, 01 May 2025 11:47:33 UTC
APIs	✅	Thu, 01 May 2025 11:47:33 UTC

Tasks are run on every commit but only new migration files are pushed.
Close and reopen this PR if you want to apply changes from existing seed or migration files.

Tasks	Status	Updated
Configurations	✅	Thu, 01 May 2025 11:47:34 UTC
Migrations	✅	Thu, 01 May 2025 11:47:34 UTC
Seeding	✅	Thu, 01 May 2025 11:47:34 UTC
Edge Functions	✅	Thu, 01 May 2025 11:47:34 UTC

View logs for this Workflow Run ↗︎.
Learn more about Supabase for Git ↗︎.

tnyo43 · 2025-04-20T06:59:04Z

frontend/packages/db-structure/src/parser/schemarb/parser.ts

+  const idPrimaryKeyConstraint: PrimaryKeyConstraint = {
+    type: 'PRIMARY KEY',
+    name: 'PRIMARY_id',
+    columnName: 'id',
+  }


It generates PRIMARY KEY constraint object at the same time of it generates id column.

tnyo43 · 2025-04-20T07:10:29Z

frontend/packages/db-structure/src/parser/schemarb/parser.ts

+            if (index.unique && index.columns[0]) {
+              const uniqueConstraint: UniqueConstraint = {
+                type: 'UNIQUE',
+                name: `UNIQUE_${index.columns[0]}`,
+                columnName: index.columns[0],
+              }
+              constraints.push(uniqueConstraint)
+            }


It will set UNIQUE constraints when unique index objects is created.
https://api.rubyonrails.org/v8.0.2/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_index

I understand this is the only way to set unique constraints on the database.

In order to add a uniqueness database constraint on your database, use the add_index statement in a migration and include the unique: true option.
https://guides.rubyonrails.org/active_record_validations.html#:~:text=In%20order%20to%20add%20a%20uniqueness%20database%20constraint%20on%20your%20database%2C%20use%20the%20add_index%20statement%20in%20a%20migration%20and%20include%20the%20unique%3A%20true%20option.

You can see how it works in index (unique: true) test case.

I have the same understanding!👍

tnyo43 · 2025-04-20T07:12:46Z

frontend/packages/db-structure/src/parser/schemarb/parser.ts

@@ -278,6 +309,51 @@ function extractRelationshipTableNames(
  return ok([primaryTableName, foreignTableName])
 }

+function extractCheckConstraint(


Here is a function to get check constraint from add_check_constraint statement.

It will extract the table name, detail and constraint name from the statement.

tnyo43 · 2025-04-20T07:24:10Z

Oops, it looks createParserTestCases function is shared among the parser tests 👀
So it will cause something wrong if I change the object for a single test.
https://github.com/liam-hq/liam/actions/runs/14557016240/job/40835263403?pr=1408

However, I'm not sure if all the result must be the same. For example, index (unique: true) will make the target column be unique for the schame.rb parser, but not for the tbls parser, since it gets constraints from schema's constraints section.

The expected objects of the test cases of schama.rb's parser are different than the other parsers, especially than the tbls's parser. They will requires their own test results.

tnyo43 · 2025-04-22T12:06:01Z

frontend/packages/db-structure/src/parser/schemarb/index.test.ts

    })

-    it('foreign key (one-to-many)', async () => {
+    it('foreign key', async () => {


I created a test of "foreign key" to test the behaviour with add_foreign_key by checking both relationships and constraints.
Since the existing cases like "foreign key (one-to-many)" were intended to test relationship cardinalities, I grouped them under a describe block named "foreign key cardinality". (I think using "Hide whitespace" to will make the diff easier to read)

qodo-merge-pro-for-open-source · 2025-04-22T12:23:36Z

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review Constraint Naming The unique constraint naming convention uses a hardcoded prefix "UNIQUE_" followed by the column name. This approach might lead to naming conflicts if multiple unique constraints exist on the same column or if the constraint is on multiple columns. const uniqueConstraint: UniqueConstraint = { type: 'UNIQUE', name: `UNIQUE_${index.columns[0]}`, columnName: index.columns[0], Error Handling The code doesn't handle the case where a foreign key constraint references a table that doesn't exist yet. This could lead to constraints not being properly added to tables that are defined after their references. const foreignTable = this.tables.find( (table) => table.name === foreignTableName, ) if (foreignTable) { foreignTable.constraints[foreignKeyConstraint.name] = foreignKeyConstraint } }

qodo-merge-pro-for-open-source · 2025-04-22T12:24:15Z

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Fix multi-column unique constraints The unique constraint is being created with a hardcoded name pattern that doesn't handle multi-column indexes correctly. For multi-column indexes, the constraint should include all column names or use the index name to ensure uniqueness. frontend/packages/db-structure/src/parser/schemarb/parser.ts [143-168] function extractTableDetails( blockNodes: Node[], ): [Column[], Index[], Constraint[]] { const columns: Column[] = [] const indexes: Index[] = [] const constraints: Constraint[] = [] for (const blockNode of blockNodes) { if (blockNode instanceof StatementsNode) { for (const node of blockNode.compactChildNodes()) { if ( node instanceof CallNode && node.receiver instanceof LocalVariableReadNode && node.receiver.name === 't' ) { if (node.name === 'index') { const index = extractIndexDetails(node) indexes.push(index) - if (index.unique && index.columns[0]) { + if (index.unique && index.columns.length > 0) { const uniqueConstraint: UniqueConstraint = { type: 'UNIQUE', - name: `UNIQUE_${index.columns[0]}`, + name: `UNIQUE_${index.name \|\| index.columns.join('_')}`, columnName: index.columns[0], + columns: index.columns, } constraints.push(uniqueConstraint) } continue } `[To ensure code accuracy, apply this suggestion manually]` Suggestion importance[1-10]: 8 __ Why: The current implementation doesn't properly handle multi-column unique indexes, as it only uses the first column for the constraint name and doesn't store all columns. The improved code fixes this by using either the index name or joining all column names for the constraint name, and storing all columns in the constraint.	Medium
Possible issue	Fix invalid check constraint The test case contains a logically impossible check constraint condition: "age >= 20 and age < 20". This condition can never be true and would prevent any rows from being inserted. Use a valid condition like "age >= 20 and age < 100" instead. frontend/packages/db-structure/src/parser/schemarb/parser.ts [395-413] it('check constraint', async () => { const { value } = await processor(/* Ruby */ ` create_table "users" do \|t\| t.integer "age" end - add_check_constraint "users", "age >= 20 and age < 20", name: "age_range_check" + add_check_constraint "users", "age >= 20 and age < 100", name: "age_range_check" `) expect(value.tables['users']?.constraints).toEqual({ PRIMARY_id: aPrimaryKeyConstraint({ name: 'PRIMARY_id', columnName: 'id', }), age_range_check: aCheckConstraint({ name: 'age_range_check', - detail: 'age >= 20 and age < 20', + detail: 'age >= 20 and age < 100', }), }) }) `[To ensure code accuracy, apply this suggestion manually]` Suggestion importance[1-10]: 7 __ Why: The test case contains a logically impossible check constraint condition ("age >= 20 and age < 20") that would prevent any rows from being inserted. The fix replaces it with a valid condition ("age >= 20 and age < 100") that makes logical sense.	Medium
Learned best practice	Validate that extracted string values are non-empty before using them in critical operations Add validation to ensure that both tableName and detail are non-empty strings before proceeding with constraint creation. Empty strings could lead to invalid constraints being created. frontend/packages/db-structure/src/parser/schemarb/parser.ts [312-330] function extractCheckConstraint( argNodes: Node[], ): Result< { tableName: string; constraint: CheckConstraint }, UnexpectedTokenWarningError > { const stringNodes = argNodes.filter((node) => node instanceof StringNode) if (stringNodes.length !== 2) { return err( new UnexpectedTokenWarningError( 'Check constraint must have one table name and its detail', ), ) } const [tableName, detail] = stringNodes.map((node): string => { if (node instanceof StringNode) return node.unescaped.value return '' }) as [string, string] + + if (!tableName \|\| !detail) { + return err( + new UnexpectedTokenWarningError( + 'Check constraint requires non-empty table name and detail', + ), + ) + } } `[To ensure code accuracy, apply this suggestion manually]` Suggestion importance[1-10]: 6	Low
Update

FunamaYukina

I commented on one, but the others are LGTM! Thank you!🌟

FunamaYukina · 2025-04-25T12:51:50Z

frontend/packages/db-structure/src/parser/schemarb/parser.ts

@@ -311,25 +388,31 @@ function extractForeignKeyOptions(
          case 'column':
            if (value instanceof StringNode || value instanceof SymbolNode) {
              relation.foreignColumnName = value.unescaped.value
+              foreignKeyConstraint.columnName = value.unescaped.value


(sorry, I wasn't able to submit my comment.)
In lines 391, 397, and 406, it would be better to set “foreignKeyConstraint.name” as well. The name seemed to remain empty.

like this?💭

case 'column' foreignKeyConstraint.name = `fk_${value.unescaped.value}`

case 'on_update' foreignKeyConstraint.name = `on_update_${updateConstraint}`

case 'on_delete' foreignKeyConstraint.name = `on_delete_${updateConstraint}`

Thanks for pointing it out, but unfortunately I can't reproduce the problem on my end.
Could you please share the schema you used? That would help me understand the problem more easily.

It seemds like the add_foreign_key method always provides a name property, even if it isn't explicitly set, so I guess there is no need toadd extra lines for it 🤔
In any cases, a concrete example will be super helpful 😉

:name
The constraint name. Defaults to fk_rails_<identifier>.
https://api.rubyonrails.org/v4.2.0/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_foreign_key

📝 To reproduce, visit https://liam-app-git-feat-schemarb-constraints-route-06-core.vercel.app/erd/p/github.com/mastodon/mastodon/blob/1bc28709ccde4106ab7d654ad5888a14c6bb1724/db/schema.rb?active=account_aliases

The constraint name should be fk_rails_<identifier> and the identifier is a 10 character long random HEX string if the name is not provided (please refer to this).
I created a random HEX string generator and set the constraint name and column name if not provided explicitly in this commit 83cc5e5
Thanks for your kind review 👍

Thank you for looking into this!
As you pointed out, fk_rails_<identifier> is hard to understand, so I think choosing a simpler naming approach makes sense.👍
I think it's fine to use the relationship_name as it is, but how about something likefk_account_aliases_account_id?（I think the current name is accounts_id_to_account_conversations_account_id.）

frontend/packages/db-structure/src/parser/schemarb/parser.ts:438

foreignKeyConstraint.name = `fk_${relation.foreignTableName}_${relation.foreignColumnName}`

I'm afraid I've reviewed this many times, but I hope you'll consider it.🙏

No problem at all, but thanks for your suggestion!
I think that naming makes sense 👍
I modified it in a59b2f6

Thank you so much! It's perfect🌟🌟

Foreign key constraints name will include 10 character long random identifier if not specified. ref: https://api.rubyonrails.org/v4.2.0/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-add_foreign_key The original implementation returns 10 character long random HEX string (e.g. "c5b6f2d87a", "4e2f7ab9c1", ...) ref: https://github.com/rails/rails/blob/77fe87cccd90859e67c958cbf63d7e5662174fd8/activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb#L984-L988

frontend/packages/db-structure/src/parser/schemarb/parser.ts

…lationship name. I think the logic was too complicated #1408 (comment)

tnyo43 · 2025-04-26T10:23:21Z

frontend/packages/db-structure/src/parser/schemarb/parser.ts

  if (relation.foreignColumnName === '') {
-    relation.foreignColumnName = `${singularize(relation.primaryTableName)}_id`
+    const columnName = `${singularize(relation.primaryTableName)}_id`
+    relation.foreignColumnName = columnName
+    foreignKeyConstraint.columnName = columnName
  }

  if (relation.name === '') {
-    relation.name = defaultRelationshipName(
+    const relationshipName = defaultRelationshipName(
      relation.primaryTableName,
      relation.primaryColumnName,
      relation.foreignTableName,
      relation.foreignColumnName,
    )
+    relation.name = relationshipName
+    foreignKeyConstraint.name = relationshipName
  }
 }


I set the same values for the constraint's name and columnName as those of the relationship's name and columnName if they are not specified explicitly.
Although that name do not strictly follow the add_foreign_key specification (fk_rails_<identifier>. identifier is a 10 character long random string), I chose to assign these values because reproducing the exact specification would make the implementation overly complex.

I initially tried implementing the specification-compliant names (please check this commit if you are interested in), but the implementation became too complicated, so I decided not to proceed with it.

Co-authored-by: FunamaYukina <FunamaYukina@@users.noreply.github.com> ref: #1408 (comment)

FunamaYukina

LGTM! Awesome!

tnyo43 added 5 commits April 20, 2025 10:57

✨ update parser to set constraints object

8db5874

✨ set PRIMARY KEY constraint for "id" column

1b903a0

✨ set FOREIGN KEY constraint

7179225

✨ set CHECK constraint when add_check_constraint is set

2f880cf

✨ set UNIQUE constraint when index is set with unique: true

e4d0639

github-actions bot assigned tnyo43 Apr 20, 2025

This comment was marked as resolved.

Sign in to view

tnyo43 commented Apr 20, 2025

View reviewed changes

tnyo43 added 4 commits April 22, 2025 20:46

🔧 revert chagens of testcases.ts

ecd3ace

The expected objects of the test cases of schama.rb's parser are different than the other parsers, especially than the tbls's parser. They will requires their own test results.

🔧 fix test cases by mentioning their own expected objects

ee6053f

🔧 update snapshots

53fee26

add changeset

8d71055

vercel bot deployed to Preview – liam-erd-sample April 22, 2025 11:53 View deployment

vercel bot deployed to Preview – liam-app April 22, 2025 11:55 View deployment

tnyo43 commented Apr 22, 2025

View reviewed changes

tnyo43 marked this pull request as ready for review April 22, 2025 12:23

tnyo43 requested a review from a team as a code owner April 22, 2025 12:23

tnyo43 requested review from hoshinotsuyoshi, FunamaYukina, junkisai, MH4GF and NoritakaIkeda and removed request for a team April 22, 2025 12:23

qodo-merge-pro-for-open-source bot added the Review effort 3/5 label Apr 22, 2025

tnyo43 requested review from hoshinotsuyoshi and FunamaYukina April 25, 2025 04:08

FunamaYukina approved these changes Apr 25, 2025

View reviewed changes

FunamaYukina reviewed Apr 25, 2025

View reviewed changes

vercel bot deployed to Preview – liam-erd-sample April 26, 2025 06:55 View deployment

vercel bot deployed to Preview – liam-app April 26, 2025 06:57 View deployment

tnyo43 added 2 commits April 26, 2025 15:58

🐛 set columnName and name of the constraint if it's not provided

83cc5e5

tnyo43 force-pushed the feat/schemarb-constraints branch from f792f4e to 83cc5e5 Compare April 26, 2025 06:58

vercel bot deployed to Preview – liam-erd-sample April 26, 2025 06:59 View deployment

vercel bot deployed to Preview – liam-app April 26, 2025 07:01 View deployment

tnyo43 commented Apr 26, 2025

View reviewed changes

frontend/packages/db-structure/src/parser/schemarb/parser.ts Outdated Show resolved Hide resolved

🔧 integrate the logic to generate foreign key constraint name with re…

d893b3b

…lationship name. I think the logic was too complicated #1408 (comment)

vercel bot deployed to Preview – liam-erd-sample April 26, 2025 10:02 View deployment

vercel bot deployed to Preview – liam-app April 26, 2025 10:04 View deployment

Merge branch 'main' into feat/schemarb-constraints

4ac6aa3

vercel bot deployed to Preview – liam-erd-sample April 26, 2025 10:16 View deployment

vercel bot deployed to Preview – liam-docs April 26, 2025 10:17 View deployment

vercel bot deployed to Preview – liam-app April 26, 2025 10:19 View deployment

tnyo43 commented Apr 26, 2025

View reviewed changes

🔧 fix foreignKeyConstraint name

a59b2f6

Co-authored-by: FunamaYukina <FunamaYukina@@users.noreply.github.com> ref: #1408 (comment)

vercel bot deployed to Preview – liam-erd-sample May 1, 2025 11:47 View deployment

vercel bot deployed to Preview – liam-app May 1, 2025 11:50 View deployment

FunamaYukina approved these changes May 2, 2025

View reviewed changes

FunamaYukina added this pull request to the merge queue May 2, 2025

Merged via the queue into main with commit cd07237 May 2, 2025
18 checks passed

FunamaYukina deleted the feat/schemarb-constraints branch May 2, 2025 01:54

liam-changeset-ci-trigger bot mentioned this pull request May 2, 2025

Version Packages #1577

Open

tnyo43 mentioned this pull request May 5, 2025

✨ Enhance the PostgreSQL parser to support Constraints #1587

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ enhance the schema.rb parser to support Constraints #1408

✨ enhance the schema.rb parser to support Constraints #1408

tnyo43 commented Apr 20, 2025 •

edited

Loading

changeset-bot bot commented Apr 20, 2025 •

edited

Loading

vercel bot commented Apr 20, 2025 •

edited

Loading

supabase bot commented Apr 20, 2025 •

edited

Loading

This comment was marked as resolved.

tnyo43 Apr 20, 2025

tnyo43 Apr 20, 2025 •

edited

Loading

FunamaYukina Apr 21, 2025

tnyo43 Apr 20, 2025

tnyo43 commented Apr 20, 2025

tnyo43 Apr 22, 2025

qodo-merge-pro-for-open-source bot commented Apr 22, 2025

qodo-merge-pro-for-open-source bot commented Apr 22, 2025 •

edited

Loading

FunamaYukina left a comment

FunamaYukina Apr 25, 2025 •

edited

Loading

tnyo43 Apr 26, 2025 •

edited

Loading

tnyo43 Apr 26, 2025

FunamaYukina Apr 28, 2025

tnyo43 May 1, 2025

FunamaYukina May 2, 2025

tnyo43 Apr 26, 2025

FunamaYukina left a comment

✨ enhance the schema.rb parser to support Constraints #1408

✨ enhance the schema.rb parser to support Constraints #1408

Conversation

tnyo43 commented Apr 20, 2025 • edited Loading

Issue

Why is this change needed?

ref

What would you like reviewers to focus on?

Testing Verification

What was done

🤖 Generated by PR Agent at 8d71055

Detailed Changes

Additional Notes

changeset-bot bot commented Apr 20, 2025 • edited Loading

🦋 Changeset detected

vercel bot commented Apr 20, 2025 • edited Loading

supabase bot commented Apr 20, 2025 • edited Loading

This comment was marked as resolved.

Choose a reason for hiding this comment

tnyo43 Apr 20, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tnyo43 commented Apr 20, 2025

Choose a reason for hiding this comment

qodo-merge-pro-for-open-source bot commented Apr 22, 2025

PR Reviewer Guide 🔍

qodo-merge-pro-for-open-source bot commented Apr 22, 2025 • edited Loading

PR Code Suggestions ✨

FunamaYukina left a comment

Choose a reason for hiding this comment

FunamaYukina Apr 25, 2025 • edited Loading

Choose a reason for hiding this comment

tnyo43 Apr 26, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FunamaYukina left a comment

Choose a reason for hiding this comment

tnyo43 commented Apr 20, 2025 •

edited

Loading

🤖 Generated by PR Agent at `8d71055`

changeset-bot bot commented Apr 20, 2025 •

edited

Loading

vercel bot commented Apr 20, 2025 •

edited

Loading

supabase bot commented Apr 20, 2025 •

edited

Loading

tnyo43 Apr 20, 2025 •

edited

Loading

qodo-merge-pro-for-open-source bot commented Apr 22, 2025 •

edited

Loading

FunamaYukina Apr 25, 2025 •

edited

Loading

tnyo43 Apr 26, 2025 •

edited

Loading